Update error handling in login to handle 429 response (too many wrong credentials at login) #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo04
added
[Type] Enhancement
|
You can test the changes on this Pull Request by downloading the APK here. |
sandymcfadden
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
You may want to have someone else take a look at the code, but I tested this out and everything works as expected.
I tested unverified accounts, invalid logins, valid logins, and after trying a number of times I saw the new error message for trying too many times as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513.
Fix
Currently, Simperium doesn't handle the error code
429which represents the user is temporarily blocked because too many failed attempts to log in.Expected Behavior
The expected behavior is to show the user a specific error message for this error:
Too many log in attempts. Try again later.Current Behavior
The user sees the wrong credentials default error.
Test
Review
Only one developer is required to review these changes, but anyone can perform the review.
Release
RELEASE-NOTES.txtwas updated in 2684451 with: